On 10/14/2013 07:09 PM, Michael S. Tsirkin wrote: > On Mon, Oct 14, 2013 at 05:56:35PM +0800, Jason Wang wrote: >> > We used to schedule the refill work unconditionally after changing the >> > number of queues. This may lead an issue if the device is not >> > up. Since we only try to cancel the work in ndo_stop(), this may cause >> > the refill work still work after removing the device. Fix this by only >> > schedule the work when device is up. >> > >> > The bug were introduce by commit 9b9cd8024a2882e896c65222aa421d461354e3f2. >> > (virtio-net: fix the race between channels setting and refill) >> > >> > Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx> >> > Cc: Michael S. Tsirkin <mst@xxxxxxxxxx> >> > Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx> > It bothers me that we look at the flag without any > locks here. > I think we'll need to take the rtnl lock at least > on restore. > True, will post v2. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
