On Thu, 2013-09-05 at 21:58 -0700, Greg Kroah-Hartman wrote: > Again, very minor fixups for later (I can even do them...) > > > +static DEVICE_ATTR(state, S_IRUGO|S_IWUSR, mic_show_state, mic_store_state); > > DEVICE_ATTR_RW() please. > > Same for the other attributes you create in this patch. > Sure, we will incorporate these changes along with your other feedback in patch 1 and post the next revision of this patch series. Thanks for the review! Sudeep Dutt _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization