On Wed, 2013-07-31 at 18:45 -0700, Greg Kroah-Hartman wrote: > On Wed, Jul 24, 2013 at 08:31:32PM -0700, Sudeep Dutt wrote: > > This patch enables the following: > > a) Initializes the Intel MIC X100 PCIe devices. > > b) Boots and shuts down the card via sysfs entries. > > c) Allocates and maps a device page for communication with the > > card driver and updates the device page address via scratchpad > > registers. > > d) Provides sysfs entries for family, stepping, state, shutdown > > status, kernel command line, IP address, ramdisk and log buffer > > information. > > That's a lot to do in one patch, almost 4 thousand lines. Can't you > break this up into some more smaller, logical, and reviewable, pieces? > Sure, we have started working on breaking up patch1 into smaller pieces. The next revision will have these changes. Thanks, Sudeep Dutt > For example, I have no idea what b) is, and how to separate it from the > things you do for a) and c). > > thanks, > > greg k-h _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
