Amit Shah <amit.shah@xxxxxxxxxx> writes:
> SIGIO should be sent when a port gets unplugged. It should only be sent
> to prcesses that have the port opened, and have asked for SIGIO to be
> delivered. We were clearing out guest_connected before calling
> send_sigio_to_port(), resulting in a sigio not getting sent to
> processes.
>
> Fix by setting guest_connected to false after invoking the sigio
> function.
>
> CC: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Amit Shah <amit.shah@xxxxxxxxxx>
Applied,
Rusty.
> ---
> drivers/char/virtio_console.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
> index 6bf0df3..3435348 100644
> --- a/drivers/char/virtio_console.c
> +++ b/drivers/char/virtio_console.c
> @@ -1534,12 +1534,14 @@ static void unplug_port(struct port *port)
> spin_unlock_irq(&port->portdev->ports_lock);
>
> if (port->guest_connected) {
> + /* Let the app know the port is going down. */
> + send_sigio_to_port(port);
> +
> + /* Do this after sigio is actually sent */
> port->guest_connected = false;
> port->host_connected = false;
> - wake_up_interruptible(&port->waitqueue);
>
> - /* Let the app know the port is going down. */
> - send_sigio_to_port(port);
> + wake_up_interruptible(&port->waitqueue);
> }
>
> if (is_console_port(port)) {
> --
> 1.8.1.4
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
