Re: Re: [PATCH V2 0/2] [BUGFIX] virtio/console: Fix two bugs of splice_write

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Amit,

Sorry for the late reply.

(2013/07/19 19:05), Amit Shah wrote:
On (Fri) 19 Jul 2013 [18:19:51], Yoshihiro YUNOMAE wrote:
Hi,

This patch set fixes two bugs of splice_write in the virtio-console driver.

[BUG1] Although pipe->nrbufs is empty, the driver tries to do splice_write.
        => This induces oops in sg_init_table().

[BUG2] No lock for competition of splice_write.
        => This induces oops in splice_from_pipe_feed() by bug of any user
           application.

These reports are written in each patch.

Changes in V2:
- Fix a locking problem for error

Thanks!

Reviewed-by: Amit Shah <amit.shah@xxxxxxxxxx>

Thank you for reviewing this patch set.

For the patches to be picked up in the stable trees, you need to
include CC: <stable@xxxxxxxxxxxxxxx> in the sign-off area of the
patches, just cc'ing in the patch posting doesn't help.  See
Documentation/stable_kernel_rules.txt.

Can you submit a v3 with that change, and also add my reviewed-by
line?

Sure. I'll add stable@ line, your reviewed-by line, and Masami's
reviewed-by line in sign-off area for each patch.

Thanks,
Yoshihiro YUNOMAE

--
Yoshihiro YUNOMAE
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: yoshihiro.yunomae.ez@xxxxxxxxxxx


_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization




[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux