On Fri, Jul 19, 2013 at 12:28:41PM +0200, Arnd Bergmann wrote: > On Friday 19 July 2013, Dan Carpenter wrote: > > debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. > > Also my static checker doesn't like it when we print the error code, but > > it's always just NULL. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > This looks wrong. debugfs_create_dir intentionally returns non-NULL so > failing to create the directory does not trigger an error condition if > debugfs is disabled. > Yeah. You're right. But the original code is still wrong and will oops if debugfs is disabled. We should set the pointer to NULL if we get a ERR_PTR(). I will send a v2 patch. regards, dan carpenter _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
