From: "Michael S. Tsirkin" <mst@xxxxxxxxxx> Date: Thu, 20 Jun 2013 14:48:13 +0300 > vhost_net_ubuf_put_and_wait has a confusing name: > it will actually also free it's argument. > Thus since commit 1280c27f8e29acf4af2da914e80ec27c3dbd5c01 Never reference commits only by SHA1 ID, it is never sufficient. Always provide, after the SHA1 ID, in parenthesis, the header line from the commit message. To be honest, I'm kind of tired of telling people they need to do this over and over again. Maybe people keep forgetting because the reason why this is an issue hasn't really sunk in. If the patch you reference got backported into another tree, it will not have the SHA1 ID, and therefore someone reading the "fix" won't be able to find the fault causing change without going through a lot of trouble. By providing the commit header line you remove that problem altogether, no ambiguity is possible. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
