Paolo Bonzini <pbonzini@xxxxxxxxxx> writes:
> Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto:
>> > My fault. I should have looked at linux/types.h (actually asm-generic/).
>>
>> Not really, __uX appear in the headers that were posted.
Which is a problem because this is a reserved namespace in C99.
>> What I'm saying is - a chance of a conflict is very remote,
>> if it happens it's a build failure so easy to debug.
>
> I'm sure that others will complain, :) but you can go ahead.
I think we should clean up the virtio headers in the kernel first.
Seems like a good thing to do given the standardization effort too.
There are lots of headers in uapi that use the C99 int types so there
doesn't seem to be a reason they couldn't be used in virtio. fuse.h
even has a:
#ifdef __KERNEL__
#include <linux/types.h>
#else
#include <stdint.h>
#endif
Which seems like a reasonable thing to do.
The only other kernel dependency is linux/if_ether.h to define
ETH_ALEN. But it seems completely reasonable to define a
VIRTIO_NET_MAC_ALEN or something like that.
This would make the virtio headers completely stand alone and includable
in userspace (without violating C99).
Perhaps it's even worth moving the headers from uapi/linux to
uapi/virtio. Rusty, what do you think?
Regards,
Anhtony Liguori
>
> Paolo
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
