On Fri, Apr 5, 2013 at 6:37 AM, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
> diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c
> index fb8faee..aefbaae 100644
> --- a/drivers/remoteproc/remoteproc_virtio.c
> +++ b/drivers/remoteproc/remoteproc_virtio.c
> @@ -196,7 +196,7 @@ static void rproc_virtio_reset(struct virtio_device *vdev)
> }
>
> /* provide the vdev features as retrieved from the firmware */
> -static u32 rproc_virtio_get_features(struct virtio_device *vdev)
> +static u64 rproc_virtio_get_features(struct virtio_device *vdev)
> {
> struct rproc_vdev *rvdev = vdev_to_rvdev(vdev);
>
> @@ -210,6 +210,9 @@ static void rproc_virtio_finalize_features(struct virtio_device *vdev)
> /* Give virtio_ring a chance to accept features */
> vring_transport_features(vdev);
>
> + /* Make sure we don't have any features > 32 bits! */
> + BUG_ON((u32)vdev->features != vdev->features);
> +
> /*
> * Remember the finalized features of our vdev, and provide it
> * to the remote processor once it is powered on.
> @@ -220,6 +223,7 @@ static void rproc_virtio_finalize_features(struct virtio_device *vdev)
> * extension of the virtio resource entries.
> */
> rvdev->gfeatures = vdev->features;
> +
> }
Seems like an extra newline has sneaked in - we should probably leave it out.
Otherwise
Acked-by: Ohad Ben-Cohen <ohad@xxxxxxxxxx>
Thanks!
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
