On Tue, 2013-04-02 at 18:39 +0300, Michael S. Tsirkin wrote:
> On Tue, Apr 02, 2013 at 11:31:37PM +0800, Asias He wrote:
> > In vhost_scsi_handle_vq:
> >
> > tv_tpg = vs->vs_tpg[target];
> > if (!tv_tpg) {
> > ....
> > return
> > }
> >
> > tv_cmd = vhost_scsi_allocate_cmd(tv_tpg, &v_req,
> >
> > 1) vs->vs_tpg[target] might change after the NULL check and 2) the above
> > line might access tv_tpg from vs->vs_tpg[target]. To prevent 2), use
> > ACCESS_ONCE. Thanks mst for catching this up!
> >
> > Signed-off-by: Asias He <asias@xxxxxxxxxx>
>
> OK this might be ok for 3.9.
>
> Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
>
> Nicholas can you pick this up pls?
>
Applying to target-pending/master now.
> For 3.10 I still think it's best to get rid of it
> and stick vs->vs_tpg in vq->private_data.
>
Your call here. Given that vhost-scsi-pci code + Seabios w/ virtio-scsi
enabled will be broken without Asias's two extra vq->private_data and
initialize vq->last_used_idx changes on the list, they will certainly
need to hit 3.9.x code once your happy to ACK for v3.10.
Asias, I assume you'll be updating this soon..?
--nab
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
