Re: [PATCH 05/22] virtio: add support for 64 bit features.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 21, 2013 at 11:06 AM, Cornelia Huck
<cornelia.huck@xxxxxxxxxx> wrote:
> On Thu, 21 Mar 2013 18:59:26 +1030
> Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
>
>> Change the u32 to a u64, and make sure to use 1ULL everywhere!
>>
>> Cc: Ohad Ben-Cohen <ohad@xxxxxxxxxx>
>> Cc: Brian Swetland <swetland@xxxxxxxxxx>
>> Cc: Cornelia Huck <cornelia.huck@xxxxxxxxxx>
>> Cc: Pawel Moll <pawel.moll@xxxxxxx>
>> Cc: Christian Borntraeger <borntraeger@xxxxxxxxxx>
>> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
>> ---
>>  drivers/char/virtio_console.c          |    2 +-
>>  drivers/lguest/lguest_device.c         |   10 +++++-----
>>  drivers/remoteproc/remoteproc_virtio.c |    6 +++++-
>>  drivers/s390/kvm/kvm_virtio.c          |   10 +++++-----
>>  drivers/virtio/virtio.c                |   12 ++++++------
>>  drivers/virtio/virtio_mmio.c           |   14 +++++++++-----
>>  drivers/virtio/virtio_pci.c            |    5 ++---
>>  drivers/virtio/virtio_ring.c           |    2 +-
>>  include/linux/virtio.h                 |    2 +-
>>  include/linux/virtio_config.h          |    8 ++++----
>>  tools/virtio/linux/virtio.h            |    2 +-
>>  tools/virtio/linux/virtio_config.h     |    2 +-
>>  12 files changed, 41 insertions(+), 34 deletions(-)

I guess you would need to update the feature bits in remoteproc as well?
e.g. something like:

diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h
index faf3332..148a503 100644
--- a/include/linux/remoteproc.h
+++ b/include/linux/remoteproc.h
@@ -296,8 +296,8 @@ struct fw_rsc_vdev_vring {
 struct fw_rsc_vdev {
        u32 id;
        u32 notifyid;
-       u32 dfeatures;
-       u32 gfeatures;
+       u64 dfeatures;
+       u64 gfeatures;
        u32 config_len;
        u8 status;
        u8 num_of_vrings;
@@ -470,8 +470,8 @@ struct rproc_vdev {
        struct rproc *rproc;
        struct virtio_device vdev;
        struct rproc_vring vring[RVDEV_NUM_VRINGS];
-       unsigned long dfeatures;
-       unsigned long gfeatures;
+       u64 dfeatures;
+       u64 gfeatures;
 };

Thanks,
Sjur
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux