Il 12/03/2013 10:55, Michael S. Tsirkin ha scritto: > > Why? Why should qemu prevent from improving the driver and the benefit > > to the other user of the driver? Kvm tool is already using it since last > > Aug. This adds the missing disk hotplug support to kvm tool. > > Basically we shouldn't add stuff to kernel for a single user. > Before we commit to support features forever, let's take the time > to see that the interfaces satisfy the requirements of multiple users. The userspace components of vhost-scsi do not need any new kernel API to get this new feature. In fact, there is no new kernel API introduced by the hotplug/hotunplug patches. > > Plus, this is not a pure "feature", it is designed in virtio-scsi spec. > > The spec doesn't say it's a mandatory feature or did I miss something? It's not mandatory to support hotplug. However, it is mandatory for the device to provide an event virtqueue, even if it will never report an event and it will do nothing with the virtqueue. For this reason, a compliant userspace must already have all the support for this. Paolo _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
