Hi Rusty, The two similar functions in vringh and virtqueue for turning on interrupts has opposite return values if there are buffers available in the ring. I think it would be better if these two functions aligned the use of return values. Maybe it's just me, but I got the logic for re-scheduling NAPI wrong due to this. /** * vringh_notify_enable_kern - we want to know if something changes. * @vrh: the vring. * * This always enables notifications, but returns true if there are * now more buffers available in the vring. */ bool vringh_notify_enable_kern(struct vringh *vrh) /** * virtqueue_enable_cb - restart callbacks after disable_cb. * @vq: the struct virtqueue we're talking about. * * This re-enables callbacks; it returns "false" if there are pending * buffers in the queue, .... */ bool virtqueue_enable_cb(struct virtqueue *_vq) Regards. Sjur _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
