On 02/06/2013 09:40 AM, Greg KH wrote: > On Wed, Feb 06, 2013 at 10:38:36AM +1030, Rusty Russell wrote: >> Amit Shah <amit.shah@xxxxxxxxxx> writes: >>> On (Mon) 04 Feb 2013 [10:09:05], Rusty Russell wrote: >>>> Amit Shah <amit.shah@xxxxxxxxxx> writes: >>>>> On (Thu) 17 Jan 2013 [13:21:32], sjur.brandeland@xxxxxxxxxxxxxx wrote: >>>>>> From: Sjur Brændeland <sjur.brandeland@xxxxxxxxxxxxxx> >>>>>> >>>>>> Don't access uninitialized work-queue when removing device. >>>>>> The work queue is initialized only if the device multi-queue. >>>>>> So don't call cancel_work unless this is a multi-queue device. >>>>>> >>>>>> This fixes the following panic: >>>>> >>>>> [snip] >>>>> >>>>>> Signed-off-by: Sjur Brændeland <sjur.brandeland@xxxxxxxxxxxxxx> >>>>> >>>>> Acked-by: Amit Shah <amit.shah@xxxxxxxxxx> >>>>> >>>>>> This fix is intended of v3.8. >>>>> >>>>> Should also be CC'ed to stable@ >> ... >>>> I've already sent it to Linus. Sjur said: "This fix is intended of >>>> v3.8.". If it needs to be in -stable, please tell me and I'll fwd it >>>> manually. >>> >>> This can result in a panic when removing the device or module (when >>> not using multiport). I'd vote for submitting to stable. >>> >>> Amit >> >> OK stable, please cherry-pick from Linus' tree: >> >> commit b26ada9abe26290b1dcd06075935b977548c50db >> Author: Sjur Brændeland <sjur.brandeland@xxxxxxxxxxxxxx> >> Date: Tue Jan 22 09:50:26 2013 +1030 >> >> virtio_console: Don't access uninitialized data. > > $ git show b26ada9abe26290b1dcd06075935b977548c50db > fatal: bad object b26ada9abe26290b1dcd06075935b977548c50db > > What am I missing here? It seems just in rusty's tree but not in linus' tree. http://git.kernel.org/?p=linux/kernel/git/rusty/linux.git;a=commitdiff;h=b26ada9abe26290b1dcd06075935b977548c50db Thanks, Wanlong Gao > > greg k-h > _______________________________________________ > Virtualization mailing list > Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx > https://lists.linuxfoundation.org/mailman/listinfo/virtualization > _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
