Asias He <asias@xxxxxxxxxx> writes: > On 01/17/2013 06:29 PM, Rusty Russell wrote: >> Getting use of virtio rings correct is tricky, and a recent patch saw >> an implementation of in-kernel rings (as separate from userspace). >> >> This patch attempts to abstract the business of dealing with the >> virtio ring layout from the access (userspace or direct); to do this, >> we use function pointers, which gcc inlines correctly. >> >> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx> >> --- >> drivers/Makefile | 2 +- >> drivers/vhost/Kconfig | 8 + >> drivers/vhost/Kconfig.tcm | 1 + >> drivers/vhost/Makefile | 2 + >> drivers/vhost/vringh.c | 818 ++++++++++++++++++++++++++++++++++++++++++ >> drivers/virtio/virtio_ring.c | 33 +- >> include/linux/virtio_ring.h | 57 +++ > > > Why vringh_notify_enable_user() and vringh_notify_disable_user() are not > declared in include/linux/virtio_ring.h? Missed that? Yes, I did... I've fixed it in my vringh branch, where I'm doing development from now on. Thanks! Rusty. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization