On Wed, Jan 16, 2013 at 10:13:28AM +0100, Stefan Hajnoczi wrote: > On Wed, Jan 16, 2013 at 03:33:24PM +0800, akong@xxxxxxxxxx wrote: > > +\change_inserted -1930653948 1358320004 > > +The command VIRTIO_NET_CTRL_MAC_ADDR_SET is used to set > > +\begin_inset Quotes eld > > +\end_inset > > + > > +physical > > +\begin_inset Quotes erd > > +\end_inset > > + > > + address of the network card. > > The "physical" address of the network card? That term is not defined > anywhere in the specification. > > Perhaps it's best to explain that the config space "mac" field and > VIRTIO_NET_CTRL_MAC_ADDR_SET both set the default MAC address which rx > filtering accepts. (The MAC table is an additional set of MAC addresses > which rx filtering accepts.) > > It would also be worth explaining that VIRTIO_NET_CTRL_MAC_ADDR_SET is > atomic whereas the config space "mac" field is not. Therefore, > VIRTIO_NET_CTRL_MAC_ADDR_SET is preferred, especially while the NIC is > up. > > Stefan It's probably best to simply make the config space field read-only if the feature bit is acked. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
