On Tue, Jan 08, 2013 at 04:28:51PM -0800, Dmitry Torokhov wrote:
> Hi Greg,
>
> On Tuesday, January 08, 2013 04:15:39 PM Greg KH wrote:
> > On Tue, Jan 08, 2013 at 03:54:54PM -0800, George Zhang wrote:
> >
> > > +/* Guest device port I/O. */
> > > +struct PPNSet {
> > > + u64 num_produce_pages;
> > > + u64 num_consume_pages;
> > > + u32 *produce_ppns;
> > > + u32 *consume_ppns;
> > > + bool initialized;
> > > +};
> >
> > I know this is a private structure to the driver, so it's not that big
> > of a deal at all, but the naming for this is a bit odd (mixed case.)
> >
> > Not a show stopper at all, but if you had run checkpatch.pl on it, it
> > would have warned you about this.
>
> Surprisingly it does not:
>
> [dtor@dtor-ws vmci]$ ./scripts/checkpatch.pl -f
> drivers/misc/vmw_vmci/vmci_queue_pair.h
> total: 0 errors, 0 warnings, 191 lines checked
>
> drivers/misc/vmw_vmci/vmci_queue_pair.h has no obvious style problems and is
> ready for submission.
>
> Also silent on the patch itself...
You might want to upgrade your version of checkpatch. As of 3.8-rc2,
this is what I get:
$ ./scripts/checkpatch.pl -f drivers/misc/vmw_vmci/vmci_queue_pair.h
WARNING: Avoid CamelCase: <PPNSet>
#28: FILE: misc/vmw_vmci/vmci_queue_pair.h:28:
+struct PPNSet {
total: 0 errors, 1 warnings, 191 lines checked
drivers/misc/vmw_vmci/vmci_queue_pair.h has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
> We'll send a followup patch anyway.
Great.
greg k-h
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
