On Friday 21 December 2012, Amit Shah wrote: > On (Thu) 20 Dec 2012 [14:11:21], Sasha Levin wrote: > > debugfs_create_dir() returns NULL if it fails, there's little point in > > calling PTR_ERR on it. > > debugfs_create_dir() does return an error value if debugfs is not > enabled. > > This check for !pdrvdata.debugfs_dir should infact use > IS_ERR_OR_NULL(). Care to submit a patch for that? How about we fix the stub instead to return NULL when debugfs is disabled? Arnd _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization