I didn't get the resend either, so it seems our corporate mail really is eating messages. Lovely. > > > +#define IOCTLCMD(_cmd) IOCTL_VMCI_ ## _cmd > > > > I don't recall ever getting a valid answer for this (if you did, my > > appologies, can you repeat it). What in the world are you talking > > about here? Why is your driver somehow special from the thousands > > of other ones that use the in-kernel IO macros properly for an > > ioctl? Because we're morons. And unfortunately, we've shipped our product using those broken definitions: our VMX uses them to talk to the driver. So here's what we'd like to do. We will send out a patch soon that fixes the other issues you mention and also adds IOCTL definitions the proper way using _IOBLAH(). But we'd also like to retain these broken definitions for a short period, commented as such, at least until we can get out a patch release to Workstation 9, at which point we can remove them. Does that sound reasonable? Thanks! - Andy _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
