>> > Note: This patch is compile tested only. I have done the removal >> > of buffers from out-queue in handle_control_message() >> > when host has acked the close request. This seems less >> > racy than doing it in the release function. >> >> This confuses me... why are we doing this in case >> VIRTIO_CONSOLE_PORT_OPEN:? >> >> We can't pull unconsumed buffers out of the ring when the other side may >> still access it, and this seems to be doing that. > > Yes -- and it's my fault; I asked Sjur to do that in the close fops > function. Thanks Amit :-), but this was really my bad. > We should only do this in the port remove case (unplug or device > remove) -- so the original patch, with just the WARN_ON removed is the > right way. > > I'll send the revised 3/3 patch for you. Thank you. Regards, Sjur _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
