On Mon, 05 Nov 2012, Rusty Russell wrote: > Lee Jones <lee.jones@xxxxxxxxxx> writes: > > drivers/virtio/virtio_mmio.c: In function ‘vm_cmdline_set’: > > drivers/virtio/virtio_mmio.c:535:4: warning: format ‘%u’ expects argument of type ‘unsigned int *’, but argument 4 has type ‘resource_size_t *’ [-Wformat] > > > > Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx> > > Cc: virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx > > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx> > > --- > > drivers/virtio/virtio_mmio.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c > > index 6b1b7e1..077e9ca 100644 > > --- a/drivers/virtio/virtio_mmio.c > > +++ b/drivers/virtio/virtio_mmio.c > > @@ -531,7 +531,7 @@ static int vm_cmdline_set(const char *device, > > resources[0].end = memparse(device, &str) - 1; > > > > processed = sscanf(str, "@%lli:%u%n:%d%n", > > - &base, &resources[1].start, &consumed, > > + &base, (unsigned int *)&resources[1].start, &consumed, > > &vm_cmdline_id, &consumed); > > This suppresses a valid warning, leaving our code no less wrong than > before. But now it's silently wrong! > > Do you want to try again? For sure I'll try again. How does `s/%u/%p/` suit? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
