Compiling xenbus_xs.o triggers this GCC warning:
drivers/xen/xenbus/xenbus_xs.c:628:13: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
Add the obvious and trivial fix.
While we're touching this function add some equally obvious and trivial
whitespace fixes.
Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>
---
0) Triggered by compiling v3.7-rc1 using (basically) Fedora 17's current
config. Compile tested only.
1) Obligatory reference: https://lwn.net/Articles/487493/ .
drivers/xen/xenbus/xenbus_xs.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/xen/xenbus/xenbus_xs.c b/drivers/xen/xenbus/xenbus_xs.c
index 48220e1..7a2b0da 100644
--- a/drivers/xen/xenbus/xenbus_xs.c
+++ b/drivers/xen/xenbus/xenbus_xs.c
@@ -619,13 +619,14 @@ static struct xenbus_watch *find_watch(const char *token)
return NULL;
}
+
/*
* Certain older XenBus toolstack cannot handle reading values that are
* not populated. Some Xen 3.4 installation are incapable of doing this
* so if we are running on anything older than 4 do not attempt to read
* control/platform-feature-xs_reset_watches.
*/
-static bool xen_strict_xenbus_quirk()
+static bool xen_strict_xenbus_quirk(void)
{
uint32_t eax, ebx, ecx, edx, base;
@@ -635,8 +636,8 @@ static bool xen_strict_xenbus_quirk()
if ((eax >> 16) < 4)
return true;
return false;
-
}
+
static void xs_reset_watches(void)
{
int err, supported = 0;
--
1.7.11.7
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
