Il 14/08/2012 22:20, Nicholas A. Bellinger ha scritto: >>> > > Since virtio_scsi currently assumes a single vqs for data, this patch >>> > > simply changes ->cmd_vqs[1] to handle the single VirtQueue. Wrong, multiqueue works just fine. :) It's just the kernel driver that doesn't support it yet. >>> > > Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx> >>> > > Cc: Stefan Hajnoczi <stefanha@xxxxxxxxxxxxxxxxxx> >>> > > Cc: Michael S. Tsirkin <mst@xxxxxxxxxx> >>> > > Signed-off-by: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> >> > >> > This is a bugfix we need even without vhost, right? >> > > I believe so, as it appears to be stomping past the end of memory for > every virtio-scsi initialization regardless of vhost usage.. You just did a wrong merge. When commit d2ad7dd (virtio-scsi: add multiqueue capability, 2012-04-06) changed cmd_vq from pointer to array of pointers, you should have moved the following fields to the middle of the struct, just like that commit did. Paolo _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
