Thu, Jun 28, 2012 at 06:30:46AM CEST, davem@xxxxxxxxxxxxx wrote: >From: Jiri Pirko <jpirko@xxxxxxxxxx> >Date: Wed, 27 Jun 2012 17:27:46 +0200 > >> Signed-off-by: Jiri Pirko <jpirko@xxxxxxxxxx> > >Applied, but this seriously makes eth_mac_addr() completely useless. > >Technically, every eth_mac_addr() user in a software/virtual device >should behave the way virtio_net does now. I guess to. But for some HW devices eth_mac_addr() is needed (when they does not support "life" mac change") > >It therefore probably makes sense to add a boolean arg which when true >elides the netif_running() check then fixup and audit every caller. I was thinking about this. Maybe probably __eth_mac_addr() which does not have netif_running() check and eth_mac_addr() calling netif_running() check and __eth_mac_addr() after that. What do you think? Jirka _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
