On Wed, 2012-06-06 at 19:17 +0300, Michael S. Tsirkin wrote: > But why do you say at most 1 packet? > > Consider get_stats doing: > u64_stats_update_begin(&stats->syncp); > stats->tx_bytes += skb->len; > > on 64 bit at this point > tx_packets might get incremented any number of times, no? > > stats->tx_packets++; > u64_stats_update_end(&stats->syncp); > > now tx_bytes and tx_packets are out of sync by more than 1. You lost me there. No idea of what you are thinking about. There is no atomicity guarantee in SNMP counters. (Ie fetching tx_bytes and tx_packets in a transaction is not mandatory in any RFC) As long as there is no cumulative error, its OK. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
