On Fri, Jun 1, 2012 at 5:38 AM, Asias He <asias@xxxxxxxxxx> wrote: > On 05/30/2012 09:19 PM, Stefan Hajnoczi wrote: > Could you use vblk->disk->queue->queue_lock to reference the lock so that > this patch will work on top of this one: > > virtio-blk: Use block layer provided spinlock Absolutely. I'll rebased on top of your patches and resend. > BTW. Why the function name is changed to virtqueue_notify() from > virtqueue_kick_notify()? Seems Rusty renamed it. I think the latter name is > better because it is more consistent and easier to remember. > > virtqueue_kick() > virtqueue_kick_prepare() > virtqueue_kick_notify() > > I believe you used virtqueue_kick_notify() in your original patch. > See: > http://www.spinics.net/lists/linux-virtualization/msg14616.html You are right, it was renamed upstream. I liked to old name better too but am happy to use what's there now. Stefan _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
