Il 08/05/2012 04:11, Rusty Russell ha scritto: >> > For virtio-scsi multiqueue support I would like to have an easy and >> > fast way to go from a virtqueue to the internal struct for that >> > queue. >> > >> > It turns out that virtio-serial has the same need, but it gets >> > by with a simple list walk. >> > >> > This patch adds a pointer to struct virtqueue that is reserved for >> > the virtio device, and uses it in virtio-serial. > I ike the concept, but share Michael's concern with naming confusion. > > How bad would be it to get rid of the current ->priv and use > container_of() instead? ie. have virtio_pci, virtio_mmio, lguest_bus > and s390's kvm_virtio embed the struct virtqueue? How bad is not the question, it would actually be pretty good... the question is more how hard! :) lguest and s390 are a bit different from the others because ->priv points into a memory-mapped descriptor provided by the host; PCI and MMIO have lots of similarities. Looks doable... Paolo _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
