On Thu, Dec 22, 2011 at 9:16 PM, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote: > This one as a signed tag on github, in case the inline patch was > the reason you dropped this. No, and please why do you make your tag-names be your email address? That's just odd. It seems to be related to some broken SCM system that thinks that tag-names are global and somehow different from branch-names. No, the reason I didn't pull was that the games with the barriers just threw me off. They seem hacky and disgusting beyond words. And afaik there are no actual *devices* that implement virtio-mmu, and the commit that adds the mmu thing talks about qemu interfaces to. So it's still just virtual, which makes the whole thing just masturbatory, afaik. There's nothing out-of-order in virtual mmio. So the whole thing looks confused. There's never any reason to actually use the expensive sfence/rfences at all. Afaik you still just want smp_*mb() for all cases. Linus _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization