Re: [RFC PATCH net-next] enable virtio_net to return bus_info in ethtool -i consistent with emulated NICs

[Rick Jones <rick.jones2@xxxxxx>]

On 11/14/2011 02:30 PM, Ben Hutchings wrote:
> On Mon, 2011-11-14 at 13:52 -0800, Rick Jones wrote:
> > From: Rick Jones<rick.jones2@xxxxxx>
> >
> > Add a new .bus_name to virtio_config_ops then modify virtio_net to
> > call through to it in an ethtool .get_drvinfo routine to report
> > bus_info in ethtool -i output which is consistent with other
> > emulated NICs and the output of lspci.
> [...]
> > diff --git a/drivers/lguest/lguest_device.c b/drivers/lguest/lguest_device.c
> > index 0dc30ff..3724d45 100644
> > --- a/drivers/lguest/lguest_device.c
> > +++ b/drivers/lguest/lguest_device.c
> > @@ -381,6 +381,11 @@ error:
> >   	return PTR_ERR(vqs[i]);
> >   }
> >
> > +static const char *lg_bus_name(struct virtio_device *vdev)
> > +{
> > +	return "Not Implemented";
> > +}
> [...]
> > +static const char *kvm_bus_name(struct virtio_device *vdev)
> > +{
> > +	return "Not Implemented";
> > +}
> [...]
>
> Please use the existing 'not implemented' value, which is the empty
> string.

Will do.

thanks,

rick
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization