On Thu, 3 Nov 2011 03:52:11 -0400, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Thu, Nov 03, 2011 at 06:12:51PM +1030, Rusty Russell wrote: > > Based on patch by Christoph for virtio_blk speedup: > > Please credit it to Stefan - he also sent a pointer to his original > version in reply to the previous thread. > > Also shouldn't virtqueue_kick have kerneldoc comments? Yep, and I've credited it properly. > I also notices that you documented the functions bother here and in > the first patch in the headers. At least historically the kerneldoc > tools didn't parse comments at declarations, but only at the function > defintions. Did you check these actually get picked up? Gah, I'd forgotten that the kernel tendency is to put the interface documentation next to the implementation. Personally, I think extracting it is insane, but I've moved them. Thanks, Rusty. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
