On Fri, Sep 02, 2011 at 06:25:56PM +0200, Olaf Hering wrote:
> Show a modalias file in /sys/bus/vmbus/devices/*/
> Add a helper function to print the same content in modalias and uevent.
>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
Nice idea, thanks for this, one minor nit below:
> ---
> drivers/staging/hv/vmbus_drv.c | 21 ++++++++++++++++-----
> 1 file changed, 16 insertions(+), 5 deletions(-)
>
> --- a/drivers/staging/hv/vmbus_drv.c
> +++ b/drivers/staging/hv/vmbus_drv.c
> @@ -93,6 +93,14 @@ static void get_channel_info(struct hv_d
> debug_info.outbound.bytes_avail_towrite;
> }
>
> +#define VMBUS_ALIAS_LEN ((sizeof((struct hv_vmbus_device_id *)0)->guid) * 2)
> +static void print_alias_name(struct hv_device *hv_dev, char *alias_name)
> +{
> + int i;
> + for (i = 0; i < VMBUS_ALIAS_LEN; i += 2)
> + sprintf(&alias_name[i], "%02x", hv_dev->dev_type.b[i/2]);
> +}
> +
> /*
> * vmbus_show_device_attr - Show the device attribute in sysfs.
> *
> @@ -105,6 +113,7 @@ static ssize_t vmbus_show_device_attr(st
> {
> struct hv_device *hv_dev = device_to_hv_device(dev);
> struct hv_device_info device_info;
> + char alias_name[VMBUS_ALIAS_LEN + 1];
Is that too big to put on the stack? 64 bytes, right? Hm, maybe not.
Wait, hv_device_info is huge, that should be dynamic in the first place.
Olaf, not your issue, but KY, want to fix that up?
thanks,
greg k-h
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization
