> err3: > free_irq(irq, hv_acpi_dev); > err2: > bus_unregister(&hv_bus); > err1: > hv_cleanup(); Also here is an oldbie trick. You could use multiples of ten like err30, err20, and err10. That way if you can add more error handling in the middle without changing the numbering. I knew my GW-BASIC experience would come in handy one day. :) The better way to label things is based on what happens when you get there: err_irq, err_unregister, err_cleanup. Some people label things based on where the goto is, but that breaks down if there is more than one goto. It doesn't really make sense to name the destination after the starting point. regards, dan carpenter _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
