On Thu, 2011-06-16 at 14:00 -0700, Jeremy Fitzhardinge wrote: > On 06/16/2011 05:14 AM, Manuel Zerpies wrote: > > Since printk_ratelimit() shouldn't be used anymore (see comment in > > include/linux/printk.h), replace it with printk_ratelimited() > Looks OK to me, but please fix the indentation of the rest of the > statement to match. [] > > diff --git a/drivers/xen/xenbus/xenbus_xs.c b/drivers/xen/xenbus/xenbus_xs.c [] > > @@ -270,8 +271,7 @@ static void *xs_talkv(struct xenbus_transaction t, > > } > > > > if (msg.type != type) { > > - if (printk_ratelimit()) > > - printk(KERN_WARNING > > + `printk_ratelimited(KERN_WARNING Appears that it's not compile tested? A stray "`" got put before printk_ratelimited() _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization