On (Wed) 02 Mar 2011 [21:38:08], Rusty Russell wrote: > On Wed, 2 Mar 2011 13:53:06 +0530, Amit Shah <amit.shah@xxxxxxxxxx> wrote: > > A crash was observed when a device gets removed while a port is in > > use. When the port gets removed, we tried to free vq buffers. The vq > > no longer exists at this stage, just ensure we don't access it. > > > > The second patch fixes a warning where the pci region is already > > freed. I'm not sure what or how the region gets freed, any clues > > there will be helpful. > > Put a printk and WARN_ON() in the pci region freeing code, look through > the backtraces? Well what seems to be happening is kref_put() in port_fops_release() calls remove_port(), which calls device_destroy(). Now this triggers another fput() on the same file, causing port_fops_release() to be called again, which leads to device_destroy() being called on the same region. Slightly more clueful, but still clueless as to why this happens. Amit _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization