>>> On 12/7/2010 at 5:29 PM, in message <20101207222933.GA10431@xxxxxxxxxxx>,
Evgeniy Polyakov <zbr@xxxxxxxxxxx> wrote:
> On Tue, Dec 07, 2010 at 03:25:56PM -0700, Ky Srinivasan
> (ksrinivasan@xxxxxxxxxx) wrote:
>> +static void shutdown_onchannelcallback(void *context)
>> +{
>> + struct vmbus_channel *channel = context;
>> + u8 *buf;
>> + u32 buflen, recvlen;
>> + u64 requestid;
>> + u8 execute_shutdown = false;
>> +
>> + struct shutdown_msg_data *shutdown_msg;
>> +
>> + struct icmsg_hdr *icmsghdrp;
>> + struct icmsg_negotiate *negop = NULL;
>> +
>> + buflen = PAGE_SIZE;
>> + buf = kmalloc(buflen, GFP_ATOMIC);
>> +
>> + vmbus_recvpacket(channel, buf, buflen, &recvlen, &requestid);
>
> This did not change since previous review and this is wrong.
> It is the right way to crash kernel.
>
> I did not read further since this is a show-stopper imo.
Hank, do you want to respond to this comment.
Regards,
K. Y
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization
