On (Mon) Sep 20 2010 [12:19:33], Rusty Russell wrote: > On Thu, 16 Sep 2010 06:43:08 pm Amit Shah wrote: > > From: Hans de Goede <hdegoede@xxxxxxxxxx> > > > > I found this while working on a Linux agent for spice, the symptom I was > > seeing was select blocking on the spice vdagent virtio serial port even > > though there were messages queued up there. > > > > virtio_console's port_fops_poll checks port->inbuf != NULL to determine > > if read won't block. However if an application reads enough bytes from > > inbuf through port_fops_read, to empty the current port->inbuf, > > port->inbuf will be NULL even though there may be buffers left in the > > virtqueue. > > > > This causes poll() to block even though there is data to be read, > > this patch fixes this by using will_read_block(port) instead of the > > port->inbuf != NULL check. > > > > Signed-off-By: Hans de Goede <hdegoede@xxxxxxxxxx> > > Signed-off-by: Amit Shah <amit.shah@xxxxxxxxxx> > > Thanks. I assume this one should go into stable too? Yes, thanks. Amit _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
