-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/19/2010 01:24 AM, Blue Swirl wrote: >> +static inline int serial_sysfs(char *d, char *s, int n) >> +{ >> + char *di = d; > > I'd change this to: > static inline ssize_t serial_sysfs(char *d, const char *s, ssize_t n) > { > const char *di = d; > >> + >> + while (*s && n--) >> + *d++ = *s++; >> + return d - di; I would guess you mean char *const di = d; Quite different and doesn't elicit warnings from the compiler. - -- ➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkwcotsACgkQ2ijCOnn/RHQLowCgqmoJCFjfh/ySP4/PQAWKmKJ9 rAwAn1O1L3hb2nzd7altEWT/PXg8oecx =YkfO -----END PGP SIGNATURE----- _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization