On Mon, Apr 12, 2010 at 04:17:15PM +0300, Michael S. Tsirkin wrote: > virtqueue ops were introduced in the hope that we'll > have multiple implementations besides virtio_ring, > but none have surfaced so far, and given that > existing virtio ring is deployed in production > we are likely stuck with it now, so this layer just > adds complexity and overhead. > Further, the need to pass vq twice to each call > (as in dev->vq->vq_ops->kick(dev->vq) ) adds potential > for cut and paste errors. > > This patchset does the following: > - add inline wrappers converting the above to virtqueue_kick(dev->vq) > - convert all users to this API > - remove vq_ops indirection, implementing virtqueue_xx directly > in virtio_ring > > Note that if we ever want to add another vring implementation, > we'll only need to revert the last patch in the series, > devices won't have to change. Looks like I missed virtio-rng and trans_virtio. So the following are needed as well. -- MST _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
