On Fri, Mar 19, 2010 at 05:36:42PM +0530, Amit Shah wrote: > Hello, > > These patches fix a couple of small issues: > - generate a kobject change event so that udev is woken up on name > changes > - fix a crash after hot-unplug of the first console port and a > subsequent config update > > But majorly, it reworks how ports are discovered: instead of numbering > the ports individually in the host and the guest by just incrementing > a number, we now switch to a bitmap in the config space exposed by the > host to identify active ports. This lets us maintain the same > numbering used by the host and also allows for hot-unplug via the > config space. This is needed for proper migration support after > several hot-plug/unplug operations. > > I've tested these patches on my testsuite to catch any regression or > correctness issues. I've also tested all the hotplug-related changes > here. > > These should go to 2.6.34, so that we don't push out a stable release > with the older interface. > > Michael, please forward these to Linus if > everyone is OK with these. I have some concerns with the new ABI. I also expect Rusty to be back in a couple of days, maybe he'll find some time to review the patches. We'll also have to update the spec ... Would you like me to queue up the first 2 patches meanwhile? > I also have a git repo at > > git://git.kernel.org/pub/scm/linux/kernel/git/amit/vs-kernel.git master > > if you prefer to pull the patches. > Amit Shah (6): > virtio: console: Generate a kobject CHANGE event on adding 'name' > attribute > virtio: console: Check if port is valid in resize_console > virtio: console: Switch to using a port bitmap for port discovery > virtio: console: Separate out get_config in a separate function > virtio: console: Handle hot-plug/unplug config actions > virtio: console: Remove hot-unplug control message > > drivers/char/virtio_console.c | 238 ++++++++++++++++++++++++---------------- > include/linux/virtio_console.h | 15 ++- > 2 files changed, 156 insertions(+), 97 deletions(-) _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
