On Mon, Feb 08, 2010 at 06:49:39PM +1030, Rusty Russell wrote: > On Sun, 7 Feb 2010 07:37:49 pm Michael S. Tsirkin wrote: > > On Mon, Feb 01, 2010 at 07:21:02PM +0200, Michael S. Tsirkin wrote: > > > vhost-net only uses memory barriers to control SMP effects > > > (communication with userspace potentially running on a different CPU), > > > so it should use SMP barriers and not mandatory barriers for memory > > > access ordering, as suggested by Documentation/memory-barriers.txt > > > > > > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx> > > > > > > Rusty, any feedback on this one? > > Thanks! > > Yep. barrier() is correct on UP to guard against preemption. > > Acked-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx> > > Thanks, > Rusty. Dave, I see it's marked "not applicable": http://patchwork.ozlabs.org/patch/44207/ the patch applies to net-next as of b3b3f04fb587ecb61b5baa6c1c5f0e666fd12d73. Can this be queued up please? Should I resubmit with Rusty's ack? Thanks! -- MST _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
