Re: [PATCH 1/6] virtio: Initialize vq->data entries to NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 12 Feb 2010 03:32:14 pm Amit Shah wrote:
> vq operations depend on vq->data[i] being NULL to figure out if the vq
> entry is in use.
> 
> We have to initialize them to NULL to ensure we don't work with junk
> data and trigger false BUG_ONs.

Not really.  We wouldn't detect some bogus get_buf() calls if it's not NULL,
but we only *need* this since detach_bufs was added.

I've updated the commit message to reflect it.

Thanks,
Rusty.
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization

[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux