On Monday 14 December 2009, Patrick McHardy wrote:
> > + classdev = device_create(macvtap_class, &dev->dev, devt,
> > + dev, "tap%d", dev->ifindex);
> > + if (IS_ERR(classdev)) {
> > + err = PTR_ERR(classdev);
> > + macvtap_del_queues(dev);
> > + macvlan_dellink(dev, NULL);
>
> I think this may cause a double free since macvlan_dellink() will
> free the device and rtnl_newlink() will free it again on error.
Ah, right. I've changed this part a few times now, but I think introduced
the same bug again in the current version. I'll send out what I have now
if you want to take another look.
Arnd
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization
