On Tuesday 24 November 2009, Eric W. Biederman wrote: > I don't quite follow what you intend with dev_queue_xmit when the macvlan > is in one namespace and the real physical device is in another. Are > you mentioning that the packet classifier runs in the namespace where > the primary device lives with packets from a different namespace? I treat internal and external delivery very differently, the three cases are: 1. skb from real device to macvlan (macvlan_handle_frame): basically unchanged from before, except avoiding duplicate broadcasts. All skbs end up in netif_rx(vlan->dev) without clearing any data. We catch the frame in netif_receive_skb before it interacts with the namespace of the real device. 2. skb to external device (macvlan_start_xmit): if the destination is external, we just end up in dev_queue_xmit, with skb->dev set to the external device but no other changes. The data is already on the way out at this stage, so the namespace should not matter any more. 3. internal delivery: an skb from one macvlan to another gets always sent through dev_forward_skb, which is supposed to clear anything that must not leave the namespace. Does this make sense? Arnd <>< _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
