On Mon, 9 Nov 2009 10:38:39 pm Amit Shah wrote: > > 3) Don't use list_for_each_safe() to get the head entry of a list. Your > > use is buggy anyway: buf will never be NULL afterwards. > > As long as 'head' isn't the only node in the list we should loop. And > list_foreach_safe() does that. So it's OK right? If there's more than one, buf will be == head. > I'm sorry for having created more work for you; I'll send out my patches > to you in a couple of days. I spent some time on the weekend creating patches. They're not finished, but they start the process of maturing the driver to where it can handle multiple ports. The next step is real buffer management (ie. the infrastructure for more than one in flight, even though the normal console won't do this), then adding headers. I will post them now so you can take a look... Rusty. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
