> -----Original Message----- > From: Stephen Hemminger [mailto:shemminger@xxxxxxxxxxxxxxxxxxxx] > Sent: Friday, October 09, 2009 2:36 PM > To: Shreyas Bhatewara > Cc: linux-kernel; netdev; David S. Miller; Jeff Garzik; Anthony > Liguori; Chris Wright; Greg Kroah-Hartman; Andrew Morton; > virtualization; pv-drivers > Subject: Re: [PATCH 2.6.32-rc3] net: VMware virtual Ethernet NIC > driver: vmxnet3 > > On Thu, 8 Oct 2009 10:59:26 -0700 (PDT) > Shreyas Bhatewara <sbhatewara@xxxxxxxxxx> wrote: > > > Hello all, > > > > I do not mean to be bothersome but this thread has been unusually > silent. > > Could you please review the patch for me and reply with your comments > / > > acks ? > > > > Thanks. > > ->Shreyas > > > Looks fine, but just a minor style nit (can be changed after insertion > in mainline). > > The code: > > static void > vmxnet3_do_poll(struct vmxnet3_adapter *adapter, int budget, int > *txd_done, > int *rxd_done) > { > if (unlikely(adapter->shared->ecr)) > vmxnet3_process_events(adapter); > > *txd_done = vmxnet3_tq_tx_complete(&adapter->tx_queue, adapter); > *rxd_done = vmxnet3_rq_rx_complete(&adapter->rx_queue, adapter, > budget); > } > > > static int > vmxnet3_poll(struct napi_struct *napi, int budget) > { > struct vmxnet3_adapter *adapter = container_of(napi, > struct vmxnet3_adapter, napi); > int rxd_done, txd_done; > > vmxnet3_do_poll(adapter, budget, &txd_done, &rxd_done); > > if (rxd_done < budget) { > napi_complete(napi); > vmxnet3_enable_intr(adapter, 0); > } > return rxd_done; > } > > > Is simpler if you just have do_poll return rx done value. Probably Gcc > inline's it all anyway. > > static int > vmxnet3_do_poll(struct vmxnet3_adapter *adapter, int budget) > { > if (unlikely(adapter->shared->ecr)) > vmxnet3_process_events(adapter); > > vmxnet3_tq_tx_complete(&adapter->tx_queue, adapter); > return vmxnet3_rq_rx_complete(&adapter->rx_queue, adapter, > budget); > } > > > static int > vmxnet3_poll(struct napi_struct *napi, int budget) > { > struct vmxnet3_adapter *adapter = container_of(napi, > struct vmxnet3_adapter, napi); > int rxd_done; > > rxd_done = vmxnet3_do_poll(adapter, budget); > if (rxd_done < budget) { > napi_complete(napi); > vmxnet3_enable_intr(adapter, 0); > } > return rxd_done; > } Thanks Stephen. Yes, the vmxnet3_do_poll() was an inline function in the very first patch. It was thought of as a better idea to let gcc handle the inlining. I will piggyback this nit on a forthcoming change. ->Shreyas _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
