On Wed, 26 Aug 2009 06:58:28 pm Amit Shah wrote: > Saves us one cycle of alloc-add-free if the queue was full. > > Signed-off-by: Amit Shah <amit.shah@xxxxxxxxxx> Thanks, applied with one change: > @@ -323,7 +323,7 @@ static bool try_fill_recv_maxbufs(struct virtnet_info *vi, gfp_t gfp) > break; > } > vi->num++; > - } > + } while (err > 0); This is better as "while (err >= num)". The other one is right (we only need 1 buffer), this one we need to be able to fit "num" entries. Thanks! Rusty. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization