Michael S. Tsirkin wrote: > devices should have the final say over which virtio features they > support. E.g. indirect entries may or may not make sense in the context > of virtio-console. Move the common bits from virtio-pci to an inline > function and let each device call it. > What drove this in vhost? Normally, the common features are transport features and the devices should have absolutely no knowledge of transport feature (since they're transport dependent). IOW, VIRTIO_RING_F_INDIRECT_DESC is meaningless to virtio-console because virtio-console has no idea what the ring implementation is that it sits on top of. Regards, Anthony Liguori _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization