On Thu, Jul 23, 2009 at 02:10:31PM +0930, Rusty Russell wrote:
> On Wed, 22 Jul 2009 01:29:25 am Michael S. Tsirkin wrote:
> > - if (info->vector != VIRTIO_MSI_NO_VECTOR)
> > + if (info->vector != VIRTIO_MSI_NO_VECTOR) {
> > free_irq(vp_dev->msix_entries[info->vector].vector, vq);
> > + --vp_dev->msix_used_vectors;
> > + }
> >
>
> This only works because the only current caller of vp_del_vq is vp_del_vqs,
Right
> so msix_used_vectors will be 0 after all the queues have been freed.
Not 0, actually, we have vectors for control and possibly
a shared vector for all vqs.
> Make up your mind. Either find_vq allocates and del_vq frees, or it's find_vqs
> and del_vqs. I suggest the former, and setting the value VIRTIO_MSI_NO_VECTOR
> to indicate it's already freed. I think with some cleanups, that loop in
> vp_free_vectors might go away, too.
>
> Rusty.
IOW, msix_used_vectors counter will be for control and shared vector
for all vqs, excluding per-vq vectors.
Makes sense. I'll put out a patch.
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization
