On Monday 2009-07-20 18:00, Greg Kroah-Hartman wrote:>>I'm happy to announce, that after many months of discussions, Microsoft>has released their Hyper-V Linux drivers under the GPLv2. Following>this message, will be the patches that add the drivers to the>drivers/staging/ tree, and a whole bunch of cleanups.>>It's taken a long road to get here, and I'd like to thank the following>people who made this possible:> - Steve Hemminger for the initial prodding and extreme patience> - Hank Janssen for providing the code and working with me to get it> into a workable and semi-mergable state. His involvement within> Microsoft was also invaluable.> - Sam Ramji for his push within Microsoft to make this happen in a> manner that works with the Linux community.> - Novell for sponsoring my work on the Linux Driver project, without> which, this would not have even been possible. (Your title as Maintainer of Crap has been well earned. But crapshould not be maintained, it should be improved.) I took a random patch to look at(add-the-hyper-v-virtual-network-driver.patch to be precise). I thinkthe /hv/ subdirectory name should be expanded a little (to, say,/hyper-v/); we're not in the Unix days anymore where space is at sucha premium that people even strip the last e off /usr. Our wirelessdrivers also don't live in /wl/. And since hv does not seem to berelated to a hypervisor — cf. sunhv.c. As for the code… I was immediately greeted by the screaming-uppercasetypedef crap jungle that is so redundant[1] yet typical in manycommercial products. One may hope that the evolution of the postedhyper-v code brings a coding strategy breeze into the house ofMicrosoft. [1] DWORD they could have replaced by uint32_t once it becameavailable via C99's stdint.h. The LPCSTR crap only makes sense if youare a lazy typist, but I would not call code doing things like LPCSTRclean. At least it's one thing - consistent. Consistently hard toread, though._______________________________________________Virtualization mailing listVirtualization@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx://lists.linux-foundation.org/mailman/listinfo/virtualization
