On Sun, 17 May 2009 03:57:01 pm Avi Kivity wrote:
> Rusty Russell wrote:
> > +static void adjust_threshold(struct vring_virtqueue *vq,
> > + unsigned int out, unsigned int in)
> > +{
> > + /* There are really two species of virtqueue, and it matters here.
> > + * If there are no output parts, it's a "normally full" receive queue,
> > + * otherwise it's a "normally empty" send queue. */
>
> This comment is true for networking, but not for block. ++overkill with
> a ->adjust_threshold op.
No, it's true for block. It has output parts, so we should reduce threshold
when it's full. Network recvq is an example which should reduce threshold
when it's empty.
->adjust_threshold is better as an arg to vring_new_virtqueue, but it's still
not clear what the answer would be.
Rusty.
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization
